This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi fellow Card.ioers :)
I've worked on implementing cardio as a fragment over the last 3 weeks so I could integrate it on my company's product. I've essentially removed all CardIOActivity references from other classes(CardScanner, OverlayView, etc) and created a couple of Interfaces. Then, it's become more dynamic as it was just a matter of implementing those interfaces in all related classes and passing them as parameter when constructing those classes.
For instructions on how to create the fragment please read the header in CardIOFragment.
I'm creating this pull request as I see you guys use that, which is good so please review my code and please let me know. I hope I can help and contribute to this stellar SDK. Seriously, this thing rocks! Lastly, I've tested SampleApp and it worked.
You may reach out to me at [email protected]
Cheers