Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social card improvements #143

Merged
merged 39 commits into from
Jan 21, 2025
Merged

Social card improvements #143

merged 39 commits into from
Jan 21, 2025

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Mar 8, 2023 •
edited by katamartin
Loading

This PR is an attempt at using the @vercel/og library to generate OpenGraph images for our blog posts dynamically. Once merged, this will eliminate the need to manually run npm run build-cards plus uploading social cards to s3 when updating our blog, streamlining our maintenance process.

dependencies:

@vercel
Copy link

vercel bot commented Mar 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 6:53pm

@andersy005
Copy link
Member Author

andersy005 commented Mar 9, 2023 •
edited
Loading

Latest deployment: https://blog-14jvsyuhr-carbonplan.vercel.app/api/og?title=Building%20open%20source%20downscaling%20pipelines%20for%20the%20cloud&date=09-02-2022&authors=Raphael%20Hagen,Anderson%20Banihirwe,Oriana%20Chegwidden,Joe%20Hamman&wrapAuthors=false

This was referenced Dec 18, 2024
Merged
Merged
@Shane98c Shane98c requested a review from katamartin January 9, 2025 23:03
katamartin
katamartin reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great to me!

Do we want to clean up the old card metadata values so that we're consistently using the og route or leave that for a potential followup?

.gitignore Outdated Show resolved Hide resolved
pages/api/og.js Show resolved Hide resolved
This was referenced Jan 15, 2025
Merged
Merged
@Shane98c Shane98c requested a review from katamartin January 16, 2025 22:13
katamartin
katamartin reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one card that looks off. Otherwise, looks good to me!

posts/geochemical-cdr-measurements.md Show resolved Hide resolved
katamartin
katamartin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@katamartin katamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shane98c Shane98c merged commit 0e456eb into main Jan 21, 2025
9 checks passed
@Shane98c Shane98c deleted the use-vercel-og branch January 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katamartin katamartin katamartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersy005 @katamartin @Shane98c