Update unit testing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmmanuelAR
commented
Jun 25, 2024
EmmanuelAR
commented
- test batch metadata
- test initialization
- test metadata
1. test batch metadata 2. test initialization 3. test metadata
|
#2 ticket |
julienbrs
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Great work!
Please adapt the test_metadata_update.cairo. You indeed adapted it from cairo0 to cairo1, but the old cairo0 test was incomplet: it missed assertion. Please do the same assertion behaviour as for the batch_metadata_update test, but for a single metadata update
julienbrs
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.