Migrate Declaration to newer property style, class-ify ClassDefinition #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffromer
reviewed
Sep 29, 2021
| // Returns the enumerator corresponding to the most-derived type of this | ||
| // object. | ||
| auto Tag() const -> Kind { return tag; } | ||
| auto tag() const -> Kind { return tag_; } |
There was a problem hiding this comment.
Can we call this kind instead? That's what I wanted to call these methods originally, if not for the name collision with the Kind type.
There was a problem hiding this comment.
Done, #860 covers this but may as well reduce merge conflicts here.
Comment on lines
+124
to
+125
| auto alternatives() const -> llvm::ArrayRef<Alternative> { | ||
| return alternatives_; |
There was a problem hiding this comment.
Should this have a mutable overload?
There was a problem hiding this comment.
My preference is to do a mutable overload on an as-needed basis. I expect one to be added, it just didn't need one as of yet, I assume because code wasn't implemented to need it.
geoffromer
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.