Update idioms.md with changes to match the code now #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename TypedInstArgsInfo references to InstLikeTypeInfo. The type was renamed in 07efa02. - Update and correct the link to search for ValueStore (and similar) in the Context class. We must avoid the google-doc-style checks rewriting `repo:` to `repository:` in the URL. - Mention the existance of many types of Store collections now. - Remove pre-C++20 idioms in Field detection. Correct the concept based idioms to work. - Fix code indenting consistency.
|
@zygoloid Maybe you could review? The concept examples here are based on your changes in toolchain/sem_ir/typed_insts.h, but the derived-from version was something I didn't see in the code yet, so I just put it together on godbolt to make sure it would work. |
chandlerc
reviewed
Nov 25, 2024
zygoloid
approved these changes
Nov 25, 2024
zygoloid
reviewed
Nov 25, 2024
toolchain/docs/idioms.md
Outdated
Comment on lines
221
to
237
| To detect a field with a specific name with a type derived from a specified base | ||
| type, use this idiom: | ||
|
|
||
| ```cpp | ||
| // HasField<T> is true if T has a `U field` field, | ||
| // where `U` extends `BaseClass`. | ||
| template <typename T, bool Enabled = true> | ||
| inline constexpr bool HasField = false; | ||
| template <typename T> | ||
| inline constexpr bool HasField< | ||
| T, bool(std::is_base_of_v<BaseClass, decltype(T::field)>)> = true; | ||
| ``` | ||
| namespace Internal { | ||
|
|
||
| The equivalent concept is: | ||
| template <typename T, typename From> concept FieldDerivedFrom = | ||
| std::derived_from<std::remove_cvref_t<T>, From>; | ||
|
|
||
| ```cpp | ||
| } | ||
|
|
||
| // HasField<T> is true if T has a `U field` field, where `U` extends | ||
| // `BaseClass`. | ||
| template <typename T> concept HasField = requires (T x) { | ||
| { x.field } -> std::derived_from<BaseClass>; | ||
| { x.field } -> Internal::FieldDerivedFrom<BaseClass>; | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
If we're not using this idiom, maybe we should remove it from the documentation for now.
There was a problem hiding this comment.
Yeah, especially since it needs a helper. SGTM
Co-authored-by: Richard Smith <[email protected]>
chandlerc
approved these changes
Nov 25, 2024
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Nov 28, 2024
…4587) - Rename TypedInstArgsInfo references to InstLikeTypeInfo. The type was renamed in 07efa02. - Update and correct the link to search for ValueStore (and similar) in the Context class. We must avoid the google-doc-style checks rewriting `repo:` to `repository:` in the URL. - Mention the existance of many types of Store collections now. - Remove pre-C++20 idioms in Field detection. Correct the concept based idioms to work. - Fix code indenting consistency. --------- Co-authored-by: Richard Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo:torepository:in the URL.