Switch most of ImportRefResolver to non-member functions
#4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
force-pushed
the
toolchain-refactor-importref
branch
from
267ee0c
to
e7d60fa
Compare
zygoloid
force-pushed
the
toolchain-refactor-importref
branch
from
e7d60fa
to
16e5ab7
Compare
josh11b
approved these changes
Nov 26, 2024
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Nov 28, 2024
…nguage#4584) In preparation for further refactoring, switch away from member functions for most of `ImportRefResolver`. Split `ImportRefResolver` into a context class that exposes the value stores for the source and destination files, and a derived class that maintains a worklist. The idea is to statically enforce that functions that take `ImportContext` cannot accidentally add new work, because they don't have access to the work queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for further refactoring, switch away from member functions for most of
ImportRefResolver.Split
ImportRefResolverinto a context class that exposes the value stores for the source and destination files, and a derived class that maintains a worklist. The idea is to statically enforce that functions that takeImportContextcannot accidentally add new work, because they don't have access to the work queue.