Split deferred node traversal out from check.cpp #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
approved these changes
Nov 20, 2024
| Context& context, Parse::DeferredDefinitionIndex index, | ||
| Parse::FunctionDefinitionStartId node_id) -> void { | ||
| worklist_.push_back(CheckSkippedDefinition{ | ||
| index, HandleFunctionDefinitionSuspend(context, node_id)}); |
There was a problem hiding this comment.
This call to HandleFunctionDefinitionSuspend is really breaking the abstraction that these two factored out classes are trying to provide -- this isn't a reusable traversal because it also has this weird side-effect of calling a Handle function.
Please can you add a TODO to move this call out of the worklist?
Comment on lines
+105
to
+117
| // When we reach the start of a deferred definition scope, add a task to the | ||
| // worklist to check future skipped definitions in the new context. | ||
| if (IsStartOfDeferredDefinitionScope(parse_kind)) { | ||
| worklist_.PushEnterDeferredDefinitionScope(context_); | ||
| } | ||
|
|
||
| // When we reach the end of a deferred definition scope, add a task to the | ||
| // worklist to leave the scope. If this is not a nested scope, start | ||
| // checking the deferred definitions now. | ||
| if (IsEndOfDeferredDefinitionScope(parse_kind)) { | ||
| chunks_.back().checking_deferred_definitions = | ||
| worklist_.SuspendFinishedScopeAndPush(context_); | ||
| } |
There was a problem hiding this comment.
These calls make me sad for the same reason as the one in the worklist. Can you add a TODO for these also?
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Nov 28, 2024
I'm looking at adding more significant logic to checking, particularly for interop. But check.cpp is getting large, and I think just adding more logic will make it harder to reason about, so I'm looking at splitting it up. This moves out NodeIdTraversal and DeferredDefinitionWorklist because they're already independent from the other code, and are reasonably sized to have their own files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at adding more significant logic to checking, particularly for interop. But check.cpp is getting large, and I think just adding more logic will make it harder to reason about, so I'm looking at splitting it up. This moves out NodeIdTraversal and DeferredDefinitionWorklist because they're already independent from the other code, and are reasonably sized to have their own files.