Remove labels from the builtin inst kind macro #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4556 |
jonmeow
force-pushed
the
rm-builtin-label
branch
from
c450e15
to
d96f2c6
Compare
zygoloid
reviewed
Nov 20, 2024
| TypeId type_id; \ | ||
| }; | ||
| #include "toolchain/sem_ir/inst_kind.def" | ||
| // TODO: Annotate as a builtin. |
There was a problem hiding this comment.
After this refactoring is done, what does it mean for an instruction to be a builtin? I think the only special thing is that we eagerly create an instance of the instruction at the start of the file. I wonder if something like "predefined constant" would be a better name for this than "builtin".
There was a problem hiding this comment.
I was considering "singleton instruction", will bring up on #toolchain
zygoloid
approved these changes
Nov 20, 2024
jonmeow
force-pushed
the
rm-builtin-label
branch
from
d96f2c6
to
ec2ae55
Compare
bricknerb
pushed a commit
to bricknerb/carbon-lang
that referenced
this pull request
Nov 28, 2024
This is stamping out the per-instruction structs, similar to what we do elsewhere. `BuiltinInstKind::label` then finishes shifting to `InstKind::ir_name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stamping out the per-instruction structs, similar to what we do elsewhere.
BuiltinInstKind::labelthen finishes shifting toInstKind::ir_name.