Switch to using Core.BigInt as the type of the size of a type literal.
#4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes one of the few ways in which `i32` is special and gets us closer to removing it as a special case.
jonmeow
approved these changes
Oct 28, 2024
Comment on lines
+56
to
+58
| // TODO: `IntId`s with different bit-widths are considered different values | ||
| // here. Decide how we want to canonicalize these. For now this is only used | ||
| // by type literals, so we rely on the lexer picking some consistent rule. |
There was a problem hiding this comment.
I think Chandler was looking at this separately, you might want to talk with him. A TODO here might be lost, because this may be more of a TODO for the numeric literal lexer.
There was a problem hiding this comment.
I couldn't find another good place for this TODO to live. I'll try to remember it once Chandler's change lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of the few ways in which
i32is special and gets us closer to removing it as a special case.