Don't eagerly import all impls. #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, eagerly import only the impls from the api file corresponding to the current file, if any, because we need those for impl redeclaration lookup. For all other cases, load only the impls in libraries that are referenced as part of an impl lookup query.
josh11b
approved these changes
Oct 25, 2024
|
Looks like there is a test fuzzer failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, eagerly import only the impls from the api file corresponding to the current file, if any, because we need those for impl redeclaration lookup. For all other cases, load only the impls in libraries that are referenced as part of an impl lookup query.