Small refactoring to Extract for compile time. #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… On Fri, Oct 25, 2024, 11:46 AM github-actions[bot] ***@***.***> wrote:
@github-actions[bot] requested your review on: #4444
<#4444> Small
refactoring to Extract for compile time..
—
Reply to this email directly, view it on GitHub
<#4444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUNHV5ZUFCUE4IO2FQQXVDZ5KGZJAVCNFSM6AAAAABQT2YJHOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUHA4DCNRTGY2DMMA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
josh11b
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT #4363 made builds of extract.cpp go from ~15s to ~35s. I'm not sure how to really improve on this, short of adding boilerplate to the types in order to reduce template use (e.g., instead of using struct reflection to return fields, we could have something that directly returns fields). But, this switch to
MaybeTraceseems to be about a 20% build time improvement (down to ~30s), withnoinlineaccounting for a part of that.