Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vtable pointers to class layout #4407

Merged
merged 18 commits into from
Oct 16, 2024
Merged

Add vtable pointers to class layout #4407

merged 18 commits into from
Oct 16, 2024

Commits on Oct 14, 2024

  1. Virtual function call lowering test case

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d7c7920 View commit details
    Browse the repository at this point in the history

  2. Add int member to explore how struct types are created

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    71c25bc View commit details
    Browse the repository at this point in the history

  3. Ultra basic vtable pointer 

    * Still needs to check the base class to see if there's already a vtable
* Not sure what type to point to - void* is probably about right, it
  can't really be pointer-to-correctly-sized-array, because derived
  classes might make the array larger (with new virtual functions)
    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a4f2828 View commit details
    Browse the repository at this point in the history

  4. Add vtable builtin type

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3eee793 View commit details
    Browse the repository at this point in the history

  5. more vtableptr type stuff

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    55f88c1 View commit details
    Browse the repository at this point in the history

  6. Add is_dynamic field to ClassFields

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9c3fb20 View commit details
    Browse the repository at this point in the history

  7. Use is_dynamic to choose whether to add a vtable ptr

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6cb4ef0 View commit details
    Browse the repository at this point in the history

  8. Only include a vtable ptr if the base is not already dynamic

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bff07df View commit details
    Browse the repository at this point in the history

  9. Update test

    @dwblaikie
    dwblaikie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    265576e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Use the new VtableType

    @dwblaikie
    dwblaikie committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    30b186b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Add TODO comment for template dependent bases 

    Co-authored-by: Richard Smith <[email protected]>
    @dwblaikie @zygoloid
    dwblaikie and zygoloid authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0ed01c6 View commit details
    Browse the repository at this point in the history

  2. Add some angles to the vptr name since it's not a keyword 

    Co-authored-by: Richard Smith <[email protected]>
    @dwblaikie @zygoloid
    dwblaikie and zygoloid authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f959776 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @dwblaikie
    dwblaikie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e519f40 View commit details
    Browse the repository at this point in the history

  4. Support/test extends base declaration appearing after a virtual fun… 

    …ction
    @dwblaikie
    dwblaikie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    08e4d71 View commit details
    Browse the repository at this point in the history

  5. Add fail_todo for initialization of variable of type with vptr

    @dwblaikie
    dwblaikie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3f24f30 View commit details
    Browse the repository at this point in the history

  6. Avoid building the fields inst block if it's going to be replaced

    @dwblaikie
    dwblaikie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    48517c8 View commit details
    Browse the repository at this point in the history

  7. Update check message to match function name 

    Co-authored-by: Richard Smith <[email protected]>
    @dwblaikie @zygoloid
    dwblaikie and zygoloid authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8c77252 View commit details
    Browse the repository at this point in the history

  8. Fix check message in AppendToTop

    @dwblaikie
    dwblaikie committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8fb7bb5 View commit details
    Browse the repository at this point in the history