Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify some points in Member Access design #3177

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Clarify some points in Member Access design #3177

merged 4 commits into from
Sep 6, 2023

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Aug 31, 2023 •
edited
Loading

Follow-on to #3160. Incorporates decision about template specialization from #2200.

@github-actions github-actions bot requested a review from jonmeow August 31, 2023 19:50
@jonmeow jonmeow added this pull request to the merge queue Aug 31, 2023
@josh11b josh11b removed this pull request from the merge queue due to a manual request Aug 31, 2023
@josh11b josh11b requested a review from zygoloid August 31, 2023 20:25
@josh11b josh11b marked this pull request as draft August 31, 2023 20:25
@josh11b josh11b marked this pull request as ready for review August 31, 2023 20:26
@github-actions github-actions bot requested a review from jonmeow August 31, 2023 20:26
jonmeow
jonmeow approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good.

@jonmeow jonmeow enabled auto-merge August 31, 2023 20:30
@jonmeow jonmeow added this pull request to the merge queue Aug 31, 2023
@jonmeow jonmeow removed this pull request from the merge queue due to a manual request Aug 31, 2023
@jonmeow jonmeow added this pull request to the merge queue Aug 31, 2023
@jonmeow jonmeow removed this pull request from the merge queue due to a manual request Aug 31, 2023
@jonmeow
Copy link
Contributor

jonmeow commented Aug 31, 2023

Noticed you explicitly requested zygoloid's review, so not merging.

@zygoloid zygoloid added this pull request to the merge queue Sep 6, 2023
Merged via the queue into carbon-language:trunk with commit dc394b6 Sep 6, 2023
6 checks passed
@josh11b josh11b deleted the ma branch September 6, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

@zygoloid zygoloid zygoloid approved these changes

Assignees

@zygoloid zygoloid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh11b @jonmeow @zygoloid