fix(side panel): slideIn not working as expected in Storybook #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeethababu9223
requested review from
elycheea and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6501 +/- ##
=======================================
Coverage 79.83% 79.84%
=======================================
Files 394 394
Lines 12872 12872
Branches 4257 4257
=======================================
+ Hits 10277 10278 +1
+ Misses 2595 2594 -1
|
elycheea
changed the title
elycheea
changed the title
elycheea
approved these changes
Nov 25, 2024
amal-k-joy
approved these changes
Nov 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 26, 2024
9d07dab
31 checks passed
sangeethababu9223
deleted the
fix/side-panel-react-slidein-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6480
The SlideIn option is not working as expected. Its behavior is currently identical to that of the SlideOver option, which should not be the case.
What did you change?
The issue was with storybook styling. I referred web components package to update the style and HTML in
SlideInTemplate inSidePanel.stories.jsxHow did you test and verify your work?
Storybook