-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate empty state v2 #6430
Merged
matthewgallo
merged 4 commits into
carbon-design-system:main
from
davidmenendez:issue-6324
Nov 20, 2024
Merged
chore: deprecate empty state v2 #6430
matthewgallo
merged 4 commits into
carbon-design-system:main
from
davidmenendez:issue-6324
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6430 +/- ##
=======================================
Coverage 79.58% 79.59%
=======================================
Files 394 394
Lines 12861 12862 +1
Branches 4266 4266
=======================================
+ Hits 10236 10237 +1
Misses 2625 2625
|
davidmenendez
requested review from
matthewgallo and
AlexanderMelox
and removed request for
a team
November 15, 2024 16:43
elycheea
approved these changes
Nov 19, 2024
matthewgallo
approved these changes
Nov 20, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 20, 2024
e7c7f1f
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6324
note to self: update this PR or code to replace the deprecation notice block in
block
with the newdeprecationNotice
prop that will be added to theStoryDocsPage
component here https://github.com/carbon-design-system/ibm-products/pull/6419/files#diff-d1d59f3ffba9e6226e5a00cedc4dc1cf7264ae4926deb6bfd27e902febf070eeR144