Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CreateTearsheet): Dynamically disable/hide the experimentalSecondarySubmit button in CreateTearsheet #6412

Conversation

Sreejith-CS
Copy link
Contributor

Closes #6409

Currently there is no way to disable or hide the experimentalSecondarySubmit by state change. The requirement is to disable or hide experimentalSecondarySubmit according to state change.

What did you change?

Added experimentalSecondarySubmit button configuration to corresponding useEffect hooks

How did you test and verify your work?

Manual tests via storyboard

experimentalSecondarySubmit_unit_test

@Sreejith-CS Sreejith-CS requested a review from a team as a code owner November 12, 2024 07:42
@Sreejith-CS Sreejith-CS requested review from AlexanderMelox and devadula-nandan and removed request for a team November 12, 2024 07:42
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit fde3ceb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/673df804f6a37800086d006e
😎 Deploy Preview https://deploy-preview-6412--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit fde3ceb
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/673df804dbb9a70008d81f67
😎 Deploy Preview https://deploy-preview-6412--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (e7c7f1f) to head (fde3ceb).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6412      +/-   ##
==========================================
- Coverage   79.61%   79.60%   -0.02%     
==========================================
  Files         394      394              
  Lines       12872    12873       +1     
  Branches     4268     4268              
==========================================
- Hits        10248    10247       -1     
- Misses       2624     2626       +2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

AlexanderMelox
AlexanderMelox previously approved these changes Nov 14, 2024
@Sreejith-CS
Copy link
Contributor Author

@devadula-nandan Could you please review once you have time

@Sreejith-CS
Copy link
Contributor Author

@matthewgallo @devadula-nandan It would be good to review this PR when you have time

@devadula-nandan
Copy link
Contributor

devadula-nandan commented Nov 19, 2024

@Sreejith-CS
Copy link
Contributor Author

Hi @Sreejith-CS , there are some build failures, could u check them? https://github.com/carbon-design-system/ibm-products/actions/runs/11836208908/job/32980615935?pr=6412#step:6:2295

@devadula-nandan Thanks for the review. I fixed the issue

@devadula-nandan
Copy link
Contributor

waiting for the issue to get triaged, as a first pass.

Copy link
Contributor

@AlexanderMelox AlexanderMelox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@elycheea elycheea added the needs: design opinion Design question needs opinion from designer label Nov 20, 2024
@devadula-nandan devadula-nandan removed the needs: design opinion Design question needs opinion from designer label Nov 25, 2024
Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution 🎉

@devadula-nandan devadula-nandan added this pull request to the merge queue Nov 26, 2024
Merged via the queue into carbon-design-system:main with commit 2eab4db Nov 26, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Dynamically disable/hide the experimentalSecondarySubmit button in CreateTearsheet
4 participants