Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API Key Modal): heading,label and downloadlink #6298

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

anamikaanu96
Copy link
Contributor

Closes #6250 and #6251

Fixed the heading text and added aria-label and role of for APIKeyDownloader

What did you change? packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js

packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx

How did you test and verify your work? voiceover

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner October 25, 2024 12:21
@anamikaanu96 anamikaanu96 requested review from makafsal and amal-k-joy and removed request for a team October 25, 2024 12:21
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9206cac
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6724e332b6315e0009a50346
😎 Deploy Preview https://deploy-preview-6298--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 9206cac
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6724e332ae0a670007f442d4
😎 Deploy Preview https://deploy-preview-6298--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anamikaanu96 anamikaanu96 added the hacktoberfest https://hacktoberfest.com/ label Oct 25, 2024
@anamikaanu96 anamikaanu96 linked an issue Oct 25, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (dcecd22) to head (9206cac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6298      +/-   ##
==========================================
+ Coverage   79.34%   79.36%   +0.01%     
==========================================
  Files         395      395              
  Lines       12880    12882       +2     
  Branches     4256     4258       +2     
==========================================
+ Hits        10220    10224       +4     
+ Misses       2660     2658       -2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

amal-k-joy
amal-k-joy previously approved these changes Oct 30, 2024
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop name can be changed to camelCase

@anamikaanu96
Copy link
Contributor Author

prop name can be changed to camelCase

yea it should be, its added by mistake. Thanks @devadula-nandan for reviewing!

@devadula-nandan
Copy link
Contributor

devadula-nandan commented Nov 1, 2024

Hi @anamikaanu96 , all good except one last thing which is confusing.

The issue #6251 states that headings should be organized hierarchically. also, it indicates the use of H1, while I observe two H2 headings that do not follow this hierarchical structure.

should it be H2 H3 ?

edit: oh wait, they are coming from ModalHeader which is not in our control.

<ModalHeader
  title={title} // shows a h2
  label={modalLabel} // shows a h2
/>

do we need to raise an issue for carbon react? im guessing there is an active issue for this

@anamikaanu96 anamikaanu96 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into carbon-design-system:main with commit 68cb175 Nov 4, 2024
31 checks passed
@anamikaanu96 anamikaanu96 deleted the APIKeyModal branch November 4, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: API Key Modal, Same Heading Text One after the Other [a11y]: API Key Modal, Label is not descriptive
3 participants