-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(API Key Modal): heading,label and downloadlink #6298
fix(API Key Modal): heading,label and downloadlink #6298
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6298 +/- ##
==========================================
+ Coverage 79.34% 79.36% +0.01%
==========================================
Files 395 395
Lines 12880 12882 +2
Branches 4256 4258 +2
==========================================
+ Hits 10220 10224 +4
+ Misses 2660 2658 -2
|
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop name can be changed to camelCase
yea it should be, its added by mistake. Thanks @devadula-nandan for reviewing! |
Hi @anamikaanu96 , all good except one last thing which is confusing. The issue #6251 states that headings should be organized hierarchically. also, it indicates the use of H1, while I observe two H2 headings that do not follow this hierarchical structure. should it be H2 H3 ? edit: oh wait, they are coming from
do we need to raise an issue for carbon react? im guessing there is an active issue for this |
68cb175
Closes #6250 and #6251
Fixed the heading text and added aria-label and role of for APIKeyDownloader
What did you change? packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx
How did you test and verify your work? voiceover