Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: guide banner test coverage #6295

Merged
merged 13 commits into from
Oct 31, 2024

Conversation

devadula-nandan
Copy link
Contributor

@devadula-nandan devadula-nandan commented Oct 25, 2024

Closes #6263

add tests to increase code coverage

What did you change?

packages/ibm-products/src/components/Guidebanner/Guidebanner.test.js

How did you test and verify your work?

yarn test
codecov dashboard

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit e532c98
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67226ed39bdd330008ea1e72
😎 Deploy Preview https://deploy-preview-6295--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit e532c98
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67226ed3482f7a0008966026
😎 Deploy Preview https://deploy-preview-6295--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan changed the title chore: empty commit to check codecov guide banner test coverage Oct 25, 2024
@devadula-nandan devadula-nandan changed the title guide banner test coverage test: guide banner test coverage Oct 25, 2024
@devadula-nandan devadula-nandan marked this pull request as ready for review October 25, 2024 09:50
@devadula-nandan devadula-nandan requested a review from a team as a code owner October 25, 2024 09:50
@devadula-nandan devadula-nandan requested review from matthewgallo and sangeethababu9223 and removed request for a team October 25, 2024 09:50
@devadula-nandan devadula-nandan marked this pull request as draft October 25, 2024 10:54
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (17aeb86) to head (e532c98).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6295      +/-   ##
==========================================
+ Coverage   78.73%   78.85%   +0.11%     
==========================================
  Files         395      395              
  Lines       12880    12880              
  Branches     4256     4256              
==========================================
+ Hits        10141    10156      +15     
+ Misses       2739     2724      -15     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

@devadula-nandan devadula-nandan marked this pull request as ready for review October 29, 2024 09:44
@matthewgallo matthewgallo added this pull request to the merge queue Oct 31, 2024
Merged via the queue into carbon-design-system:main with commit 5b13b37 Oct 31, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase GuideBanner code coverage
3 participants