fix(datagrid): adds missing header hover styles in v2 #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadula-nandan
requested review from
makafsal and
AlexanderMelox
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
makafsal
approved these changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6272 +/- ##
==========================================
- Coverage 78.73% 78.71% -0.02%
==========================================
Files 395 395
Lines 12798 12799 +1
Branches 4214 4215 +1
==========================================
- Hits 10076 10075 -1
- Misses 2722 2724 +2
|
matthewgallo
approved these changes
Oct 22, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 22, 2024
2311bdb
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6254
adds missing header hover background style from v1 to v2.
i tried to find any relevant history if it was removed intentionally, but couldn't find any, so i am guessing it was an error.
edit: it was removed here https://github.com/carbon-design-system/ibm-products/pull/4458/files#diff-e45407e4d85d104f9e1cc2d1d1bffbe1efd297ed6d4159b83bd91e72c6afae68L435
What did you change?
packages/ibm-products-styles/src/components/Datagrid/styles/_datagrid.scss
How did you test and verify your work?
storybook