fix: csp errors on 2 illustrations #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devadula-nandan
requested review from
sangeethababu9223 and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components canceled.
|
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
approved these changes
Oct 14, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 14, 2024
ad8c2d8
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6178
moved internal fill css to fill attribute on paths in svg
What did you change?
packages/ibm-products/src/components/EmptyStates/assets/NotificationsIllustration.js
packages/ibm-products/src/components/EmptyStates/assets/NoDataIllustration.js
How did you test and verify your work?
as u can see in repro if we remove the style tag from dom, the error is gone.
we are removing the style tag in this pr, which would solve the issue.
Screen.Recording.2024-10-10.at.4.20.39.PM.mov