fix(DataGrid): add support for selectrow and nestedrow V1 #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v1-carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3887
Add support for selected nested rows in the Datagrid.
Note: This PR only covers the selectable nested row part of #3887. The second acceptance criteria in comment "Selecting parent should not select all children by default" is coming from the React table and it's hard to override. If there is subRows then child rows get selected when parent row is selected.
What did you change?
rowIdselection changed to a combination ofrowIdandindexso the nested rows will have unique Id with depthHow did you test and verify your work?
Storybook > With selectable nested rows