Issue with Column Order in DataGrid Column Customization

[marinamas]

What package(s) are you using?

• Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive) - Yes
• Legacy/CDAI
• Legacy/Security

Detailed description

Describe in detail the issue you're having.
In DataGrid with column customization , when we set Initial state having Column order and hidden columns .
Though the order of the column is mentioned, it would always add the hidden columns to end of customization component.
Expected behavior would be to have the column order retained irrespective of whether the column is hidden or not

Is this issue related to a specific component?
DataGrid
What did you expect to happen? What happened instead? What would you like to
Expected behavior would be to have the column order retained in the customization component list

What browser are you working in?
Safari
Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
2.26.0

Steps to reproduce the issue

1. Use the DataGrid along with Column Customization.
2. Set the initial state with hiddenColumns, columnOrder.
3. Add few column id under hiddenColumns. Though we mention the order of Columns the customization component adds hidden
   columns at the end in the list .
4. Though the column is hidden , the order in which it is displayed should be according to the column order

Additional information

initialState: {
columnOrder: [
"rowIndex",
"firstName",
"someone1",
"lastName",
"age",
"visits",
],
hiddenColumns: ["lastName"],
}

Acceptance criteria

Preview Give feedback

1. Column order should retain position even when column is hidden
2. Add story for column order in initialState

[elycheea]

Looks like retaining column order is the intended design based on the design guidance¹.

Footnotes

1. https://pages.github.ibm.com/cdai-design/pal/components/data-table/column-customization/usage#anatomy ↩

[elycheea]

Note, when investigating this — when we first uncheck a column, it does retain position at least in the tearsheet. May be some re-rendering that happens because we were able to replicate this behavior later.

[marinamas]

Yes .Retaining column order is intended and it works. But my concern is when we hide some columns and save the selection( I mean save to BE APIs) so when user comes back the selection is saved. But what happens is , when I give the column order( which includes both hidden and visible columns order ) and hidden columns in the initial state props of DataGrid.. the order of hidden columns is not shown as per the column order but is been pushed to the end of the list. as shown in the screenshots attached in the bug. Please let me know if you need any further details. Thanks, Marina

…

On Thu, 29 Feb, 2024, 7:59 pm elysia, ***@***.***> wrote: Looks like retaining column order *is* the intended design based on the design guidance1 <#m_8453272440226846079_user-content-fn-1-3ee9b159a388c973d3ac59b728fb5aed> . Footnotes 1. https://pages.github.ibm.com/cdai-design/pal/components/data-table/column-customization/usage#anatomy ↩ <#m_8453272440226846079_user-content-fnref-1-3ee9b159a388c973d3ac59b728fb5aed> — Reply to this email directly, view it on GitHub <#4379 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATD5SXPBGI2PN4NTAAXMUUDYV45K5AVCNFSM6AAAAABDSM76RSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGI3DIOJQHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[davidmenendez]

just needs the V1 PR reviewed #4549