-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): change placeholder and helper text colors dark themes #9987
feat(themes): change placeholder and helper text colors dark themes #9987
Conversation
@aagonzales @aledavila are there any component implications for this change or does the value change here cover everything? 👀 |
@joshblack should cover everything since like anna said we only need to make them a bit more visible so they don't match the input color. Helper text as well |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: a09e621 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c454e37c15b00078ed1f6 😎 Browse the preview: https://deploy-preview-9987--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a09e621 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c454e09aedc00081d0207 😎 Browse the preview: https://deploy-preview-9987--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a09e621 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c454e3f8f2d000763e72c 😎 Browse the preview: https://deploy-preview-9987--carbon-components-react.netlify.app |
You've made placeholder visible, but what about textDisabled? =) |
Closes #9860
Closes #9832
New colors for
$text-placeholder
and$text-helper
in themesg90
andg100
The decision was made not to add them to the layer sets and just change the global token color
Changelog
Changed
g90
$text-placeholder
from Gray 60 to Gray 50$text-helper
from Gray 50 to Gray 30g100
$text-helper
from Gray 50 to Gray 40