Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): align tooltip text to the left #9985

Merged
merged 3 commits into from
Oct 30, 2021
Merged

fix(tooltip): align tooltip text to the left #9985

merged 3 commits into from
Oct 30, 2021

Conversation

aledavila
Copy link
Contributor

Closes #9964

Adds text alignment to tooltip text

Changelog

Changed

  • add alignment left to --tooltip p. Tooltip body was center aligning when tooltip had center align prop. Wasn't happneing in the other alignments

Testing / Reviewing

Make sure tooltips are displaying correctly

@aledavila aledavila requested a review from a team as a code owner October 28, 2021 19:16
@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: f445fc2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c9998d0a89900076ac7b0

😎 Browse the preview: https://deploy-preview-9985--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: f445fc2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c9998f2c969000706cbee

😎 Browse the preview: https://deploy-preview-9985--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: f445fc2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c9998b468a90008bc8ee6

😎 Browse the preview: https://deploy-preview-9985--carbon-elements.netlify.app

@aledavila
Copy link
Contributor Author

bump @sstrubberg @dakahn

@sstrubberg sstrubberg enabled auto-merge (squash) October 29, 2021 17:42
@sstrubberg sstrubberg merged commit 71a3dde into carbon-design-system:main Oct 30, 2021
@tay1orjones tay1orjones mentioned this pull request Nov 4, 2021
Closed
tay1orjones pushed a commit to tay1orjones/carbon that referenced this pull request Nov 4, 2021
@tay1orjones
fix(tooltip): align tooltip text to the left (carbon-design-system#9985)
0dcc922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg sstrubberg was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
4 participants
@aledavila @joshblack @dakahn @sstrubberg