-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TextInput): link helper text to input in default state #9873
fix(TextInput): link helper text to input in default state #9873
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: bef7432 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/618585aa0e7c9700076f4f82 😎 Browse the preview: https://deploy-preview-9873--carbon-react-next.netlify.app |
@tombrunet still getting that error after setting the |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: bef7432 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/618585aa87ea790007c56845 😎 Browse the preview: https://deploy-preview-9873--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: bef7432 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618585aa66e6a90007547523 😎 Browse the preview: https://deploy-preview-9873--carbon-elements.netlify.app |
Nvm! Looks like it was some bug with my browser. Error's clear |
Closes #9630
The text helper was not linked to the text input via aria-describedby in it's default state causing an accessibility error when the input was disabled. This adds a helper id and sets that id to the text which should clear the error
Testing / Reviewing
TextInput in it's disabled state should not throw an error in Accessibility Checker