Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): correct input width #9829

Merged
merged 2 commits into from
Oct 12, 2021
Merged

fix(slider): correct input width #9829

merged 2 commits into from
Oct 12, 2021

Conversation

tay1orjones
Copy link
Member

Closes #9823

Corrects the slider number input width to be a fixed 64px per the spec in the issue from @laurenmrice

Changelog

Changed

  • slider: correct input width

Testing / Reviewing

  • View the slider story in both chrome and firefox, the number input should be the same width between both browsers.

@tay1orjones tay1orjones requested a review from a team as a code owner October 8, 2021 21:12
@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 5ff39de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6165a7e14b27e00008e00b42

😎 Browse the preview: https://deploy-preview-9829--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 5ff39de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6165a7e134c0cf0007156f0c

😎 Browse the preview: https://deploy-preview-9829--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 5ff39de

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6165a7e1fc22850008422b16

😎 Browse the preview: https://deploy-preview-9829--carbon-components-react.netlify.app

jnm2377
jnm2377 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on chrome and firefox 👍🏽

@laurenmrice laurenmrice self-requested a review October 11, 2021 17:47
laurenmrice
laurenmrice approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kodiakhq kodiakhq bot merged commit 1a6eaf2 into carbon-design-system:main Oct 12, 2021
@tay1orjones tay1orjones deleted the 9823-slider-width branch October 12, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[slider] text input is too wide
3 participants
@tay1orjones @jnm2377 @laurenmrice