Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): add outline variant #9792

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

janhassel
Copy link
Member

Closes #9670

Added an outline variant for the Tag component.
Background: $background
Outline: $background-inverse
Text: $text-primary
Hover: $layer-hover

Changelog

New

  • Added outline variant to tag
  • Added cool-gray, warm-gray, high-contrast and outline demos to @carbon/react storybook

Changed

  • Updated API snapshot

Testing / Reviewing

Verify visual appearance is as expected

@janhassel janhassel requested review from a team as code owners October 4, 2021 07:47
@netlify
Copy link

netlify bot commented Oct 4, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615ab2f7a789f000084a54d4

😎 Browse the preview: https://deploy-preview-9792--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 4, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: dccf795

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab1a955fc1100079885df

😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 4, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: dccf795

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab1a985a9fd0008320400

😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 4, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab2f733a2d3000716cc90

😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 4, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8b9d823

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab2f785a9fd00083225b5

😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kodiakhq kodiakhq bot merged commit d02a8e5 into carbon-design-system:main Oct 4, 2021
@janhassel janhassel deleted the tag-outline-variant branch October 4, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add a new tag option
3 participants