-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tag): add outline variant #9792
feat(tag): add outline variant #9792
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 8b9d823 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615ab2f7a789f000084a54d4 😎 Browse the preview: https://deploy-preview-9792--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: dccf795 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab1a955fc1100079885df 😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: dccf795 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab1a985a9fd0008320400 😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 8b9d823 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615ab2f733a2d3000716cc90 😎 Browse the preview: https://deploy-preview-9792--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 8b9d823 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615ab2f785a9fd00083225b5 😎 Browse the preview: https://deploy-preview-9792--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closes #9670
Added an
outline
variant for theTag
component.Background:
$background
Outline:
$background-inverse
Text:
$text-primary
Hover:
$layer-hover
Changelog
New
outline
variant to tagcool-gray
,warm-gray
,high-contrast
andoutline
demos to @carbon/react storybookChanged
Testing / Reviewing
Verify visual appearance is as expected