Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add generic support to cli for workspaces #9761

Merged

Conversation

joshblack
Copy link
Contributor

This PR makes our @carbon/cli "workspace generic" by removing the relative path for finding the workspace root. This is useful for teams outside of our own who would like to use this CLI and any related tooling.

cc @SimonFinney let me know if this is missing anything that you were looking for!

Changelog

New

Changed

  • Update relative path for workspace root to be a dynamic check

Removed

Testing / Reviewing

  • Verify that the CLI runs as expected (a sample command could be ./packages/cli/bin/carbon-cli.js sync

@joshblack joshblack requested a review from a team as a code owner September 28, 2021 14:43
@netlify
Copy link

netlify bot commented Sep 28, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 6a75fdf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6155cfc70e9d7e00074e8c45

@netlify
Copy link

netlify bot commented Sep 28, 2021

❌ Deploy Preview for carbon-components-react failed.
Built without sensitive environment variables

🔨 Explore the source changes: 6a75fdf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6155cfc7aacf2b000784315c

@netlify
Copy link

netlify bot commented Sep 28, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: 6a75fdf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6155cfc714f1d100081893a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants