-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): update grid-gap to column-gap for inline dropdown #9749
fix(styles): update grid-gap to column-gap for inline dropdown #9749
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 8095057 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615494eb7f32480008544180 😎 Browse the preview: https://deploy-preview-9749--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 8095057 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615494eb42c90a0007f20cdf 😎 Browse the preview: https://deploy-preview-9749--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 8095057 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615494eb7f32480008544182 😎 Browse the preview: https://deploy-preview-9749--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait... is the column spacing the vertical spacing or the horizontal spacing? 😭 Now I'm confused lol |
@jnm2377 haha, totally get that. I believe that column is horizontal and row is vertical spacing. |
This came from a report in Slack. Currently, our inline dropdown uses
grid-gap
which adds both row and column spacing. This PR switches it to usecolumn-gap
so that only column spacing is used.Changelog
New
Changed
Removed
Testing / Reviewing