Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update grid-gap to column-gap for inline dropdown #9749

Conversation

joshblack
Copy link
Contributor

This came from a report in Slack. Currently, our inline dropdown uses grid-gap which adds both row and column spacing. This PR switches it to use column-gap so that only column spacing is used.

image

Changelog

New

Changed

  • Update styles for dropdown so that only column spacing is used

Removed

Testing / Reviewing

  • View the deploy preview and verify that the row spacing as shown in the screenshot above no longer exists

@joshblack joshblack requested a review from a team as a code owner September 27, 2021 15:36
@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8095057

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/615494eb7f32480008544180

😎 Browse the preview: https://deploy-preview-9749--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8095057

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/615494eb42c90a0007f20cdf

😎 Browse the preview: https://deploy-preview-9749--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8095057

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/615494eb7f32480008544182

😎 Browse the preview: https://deploy-preview-9749--carbon-elements.netlify.app

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ughh... wait... after inspecting, I'm realizing it doesn't actually change the spacing. If I add column-gap: 0 specifically, it does.

Screen Shot 2021-09-29 at 11 17 10 AM

Screen Shot 2021-09-29 at 11 17 20 AM

@jnm2377
Copy link
Contributor

jnm2377 commented Sep 29, 2021

wait... is the column spacing the vertical spacing or the horizontal spacing? 😭 Now I'm confused lol

@joshblack
Copy link
Contributor Author

@jnm2377 haha, totally get that. I believe that column is horizontal and row is vertical spacing.

@jnm2377 jnm2377 self-requested a review September 29, 2021 16:25
@kodiakhq kodiakhq bot merged commit cc4ab97 into carbon-design-system:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants