Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-indicator): correct prefix value from context #9736

Merged

Conversation

tay1orjones
Copy link
Member

The wrapper ul in progress indicator wasn't getting the prefix, so styles were broken. Just a minor correction to this.context from this.prefix

Changelog

Changed

  • progress-indicator: fix prefix

Testing / Reviewing

Storybook should show that the wrapper ul in progress indicator gets the prefix in it's class:

- <ul class="undefined--progress">
+ <ul class="bx--progress">

@tay1orjones tay1orjones requested a review from a team as a code owner September 24, 2021 15:25
@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4abdde7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614df131f102f700073e84f2

😎 Browse the preview: https://deploy-preview-9736--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 497d249

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614dedfeffd616000749969e

😎 Browse the preview: https://deploy-preview-9736--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 497d249

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614dedffa2c3040007d12502

😎 Browse the preview: https://deploy-preview-9736--carbon-elements.netlify.app

@kodiakhq kodiakhq bot merged commit b510ad9 into carbon-design-system:main Sep 24, 2021
@tay1orjones tay1orjones deleted the fix-progress-indicator-prefix branch September 24, 2021 16:11
@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4abdde7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614df132198e55000879a299

😎 Browse the preview: https://deploy-preview-9736--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4abdde7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614df131d3a85000084bace4

😎 Browse the preview: https://deploy-preview-9736--carbon-components-react.netlify.app

tay1orjones added a commit to tay1orjones/carbon that referenced this pull request Sep 24, 2021
…sign-system#9736)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants