Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tile): remove position relative #9706

Merged
merged 6 commits into from
Sep 23, 2021
Merged

fix(tile): remove position relative #9706

merged 6 commits into from
Sep 23, 2021

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Sep 20, 2021

Closes #9676

This PR removes position: relative from Tile's container, bx--tile and adds it to bx--tile-selectable since it is needed to position checkmark boxes, radio buttons, etc in the selectable tiles.

Changed

  • removed position: relative from bx--tile
  • change $carbon--spacing-05 to $spacing-05 because I can

Testing / Reviewing

Check to make sure that everything looks the same with this positioning removed.

@abbeyhrt abbeyhrt requested a review from a team as a code owner September 20, 2021 22:06
@joshblack
Copy link
Contributor

@abbeyhrt I think we use position: relative for things like selectable or expandable tile where we use position: absolute to position the checkmark or chevron (just looking at the tile styles that would be my guess, at least)

@abbeyhrt
Copy link
Contributor Author

@joshblack gotcha, that makes sense. I added position: relative to bx--tile-selectable and that fixed the positioning of the checkmarks and whatnot. Let me know if that works!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2021

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4cfae41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614b8b411c53810009c2ce21

😎 Browse the preview: https://deploy-preview-9706--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4cfae41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614b8b41209f01000753a0b6

😎 Browse the preview: https://deploy-preview-9706--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4cfae41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614b8b415bede80007f77280

😎 Browse the preview: https://deploy-preview-9706--carbon-elements.netlify.app

@abbeyhrt
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tile styling interfering with IBM Cloud Cognitive PageHeader component
4 participants