-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tile): remove position relative #9706
fix(tile): remove position relative #9706
Conversation
@abbeyhrt I think we use |
@joshblack gotcha, that makes sense. I added |
DCO Assistant Lite bot All contributors have signed the DCO. |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 4cfae41 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614b8b411c53810009c2ce21 😎 Browse the preview: https://deploy-preview-9706--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 4cfae41 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614b8b41209f01000753a0b6 😎 Browse the preview: https://deploy-preview-9706--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 4cfae41 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614b8b415bede80007f77280 😎 Browse the preview: https://deploy-preview-9706--carbon-elements.netlify.app |
I have read the DCO document and I hereby sign the DCO. |
Closes #9676
This PR removes
position: relative
from Tile's container,bx--tile
and adds it tobx--tile-selectable
since it is needed to position checkmark boxes, radio buttons, etc in the selectable tiles.Changed
position: relative
frombx--tile
$carbon--spacing-05
to$spacing-05
because I canTesting / Reviewing
Check to make sure that everything looks the same with this positioning removed.