Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Carbon-React): refactor prefix with context AspectRatio --> Link #9688

Merged
merged 11 commits into from
Sep 21, 2021
Merged

feat(Carbon-React): refactor prefix with context AspectRatio --> Link #9688

merged 11 commits into from
Sep 21, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Sep 17, 2021 •
edited
Loading

ref #9687

Refactors prefix to use context for components AspectRatio thru Link 🏄🏾

Testing / Reviewing

Test that the components function and have classname prefixes as expected in the corresponding storybooks

@dakahn dakahn requested a review from a team as a code owner September 17, 2021 00:07
@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e5a6e22

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614a33af7136cf0008db3d21

😎 Browse the preview: https://deploy-preview-9688--carbon-react-next.netlify.app

@dakahn dakahn changed the title 9619-2 add prefix hook refactor feat(Carbon-React): refactor prefix with context AspectRatio --> Link Sep 17, 2021
@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e5a6e22

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614a33af29c6a4000887afc2

😎 Browse the preview: https://deploy-preview-9688--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: e5a6e22

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614a33af9881d5000818e2d2

😎 Browse the preview: https://deploy-preview-9688--carbon-components-react.netlify.app

@dakahn dakahn requested a review from a team as a code owner September 20, 2021 23:09
@dakahn dakahn requested a review from joshblack September 21, 2021 19:17
@sstrubberg sstrubberg merged commit d545dd6 into carbon-design-system:main Sep 21, 2021
@joshblack joshblack mentioned this pull request Sep 22, 2021
Merged
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
chore(lint): fixes eslint warnings (carbon-design-system#9688)
7ccdf41 
* chore(lint): fixes eslint warnings

Co-authored-by: Kenny Lam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakahn @joshblack @sstrubberg