Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change comment type for stylint-ignore comments #9673

Merged
merged 5 commits into from
Sep 28, 2021
Merged

chore: change comment type for stylint-ignore comments #9673

merged 5 commits into from
Sep 28, 2021

Conversation

dcwarwick
Copy link
Contributor

Closes #9672

Changelog

packages/type/scss/_styles.scss
packages/type/scss/modules/_styles.scss
In both files, replace a CSS-preserved comment (/* ... */) with a non-preserved comment (// ...) since the comment is only a linter instruction required at build/lint time and not in the final CSS.

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Built file carbon-components/css/carbon-components.css currently contains 472 copies of the line /* stylelint-disable number-max-precision */. After this PR is applied and the files built, it should contain none (and thus be a little over 21KB smaller!).

@dcwarwick dcwarwick requested a review from a team as a code owner September 15, 2021 18:51
@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 270a0f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61532745e611640008b87224

😎 Browse the preview: https://deploy-preview-9673--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 270a0f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6153274546b7490007aa7927

😎 Browse the preview: https://deploy-preview-9673--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 270a0f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61532745f7fcd100075f5a46

😎 Browse the preview: https://deploy-preview-9673--carbon-components-react.netlify.app

@jnm2377
Copy link
Contributor

jnm2377 commented Sep 15, 2021

Looks like some of the snapshots need to be updated.

@sstrubberg sstrubberg self-requested a review September 17, 2021 18:55
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix up those testing errors and you're good to go :)

@sstrubberg sstrubberg enabled auto-merge (squash) September 28, 2021 14:31
@dcwarwick
Copy link
Contributor Author

Thanks @jnm2377 -- sorry, I've been away and just catching up with things now I'm back :-) many thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New comment polluting compiled CSS output
4 participants