-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change comment type for stylint-ignore comments #9673
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 270a0f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61532745e611640008b87224 😎 Browse the preview: https://deploy-preview-9673--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 270a0f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6153274546b7490007aa7927 😎 Browse the preview: https://deploy-preview-9673--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 270a0f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61532745f7fcd100075f5a46 😎 Browse the preview: https://deploy-preview-9673--carbon-components-react.netlify.app |
Looks like some of the snapshots need to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix up those testing errors and you're good to go :)
Thanks @jnm2377 -- sorry, I've been away and just catching up with things now I'm back :-) many thanks all. |
Closes #9672
Changelog
packages/type/scss/_styles.scss
packages/type/scss/modules/_styles.scss
In both files, replace a CSS-preserved comment (
/* ... */
) with a non-preserved comment (// ...
) since the comment is only a linter instruction required at build/lint time and not in the final CSS.Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
Built file
carbon-components/css/carbon-components.css
currently contains 472 copies of the line/* stylelint-disable number-max-precision */
. After this PR is applied and the files built, it should contain none (and thus be a little over 21KB smaller!).