Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(skeleton): fixed placement inside of a wrapper #9650

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Sep 13, 2021

Closes #9511

Added position'ing style to skeleton mixin.

Testing / Reviewing

Checkout this codepen to see what the current behavior is.

To test locally, add a textAlign: 'center' to the outermost div on the default story in the Skeleton Placeholder story.
image

Once you've added that, remove the styles to see the bug return.

@netlify
Copy link

netlify bot commented Sep 13, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7222182

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614215ffeca9fe0007cafa61

😎 Browse the preview: https://deploy-preview-9650--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 13, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7222182

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614215ffd5cb8b0008a460d0

😎 Browse the preview: https://deploy-preview-9650--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 13, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7222182

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614215ff68c65a00086a6ce3

😎 Browse the preview: https://deploy-preview-9650--carbon-elements.netlify.app

@sstrubberg sstrubberg marked this pull request as ready for review September 13, 2021 20:12
@sstrubberg sstrubberg requested a review from a team as a code owner September 13, 2021 20:12
@joshblack joshblack requested review from tw15egan and removed request for andreancardona September 13, 2021 20:18
@sstrubberg sstrubberg requested review from jnm2377 and removed request for tw15egan September 15, 2021 11:47
@kodiakhq kodiakhq bot merged commit f6c98cf into carbon-design-system:main Sep 15, 2021
@sstrubberg sstrubberg deleted the 9511-skeleton branch September 15, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container styles break skeleton alignment
3 participants