-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add display names to forward ref components #9591
feat(react): add display names to forward ref components #9591
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 488dc0d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614b6c17a1a9100008b30ab4 😎 Browse the preview: https://deploy-preview-9591--carbon-react-next.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 488dc0d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614b6c176e5b340008291629 😎 Browse the preview: https://deploy-preview-9591--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 488dc0d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614b6c17acbbb400083ffecd 😎 Browse the preview: https://deploy-preview-9591--carbon-components-react.netlify.app |
@aledavila I think updating snapshots is the last thing and then we're good to go! |
@aledavila seems like there are some test failures coming up: |
Closes #9459
Added
displayName
to components that are using forwardRefChangelog
New
Added to the following components:
Testing / Reviewing
Make sure components work as intended. Make sure display names are correct