-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Type): add new type tokens #9480
feat(Type): add new type tokens #9480
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 7320872 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612d348ff629280008c50159 😎 Browse the preview: https://deploy-preview-9480--carbon-react-next.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 7320872 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612d348f6102f700088ea2a1 😎 Browse the preview: https://deploy-preview-9480--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 7320872 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612d348f3453a700076bca14 😎 Browse the preview: https://deploy-preview-9480--carbon-components-react.netlify.app |
97864e1
to
07b4eb7
Compare
@laurenmrice @janchild can you take a look at the elements preview before we merge? https://deploy-preview-9480--carbon-elements.netlify.app/type/examples/preview/ |
6f0b7f3
to
d77c15b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I inspected all of the type tokens and found a couple of discrepancies. They should be changed to the following:
helper-text-02
should be:
Letter spacing: .16px
For heading-compact-01
and heading-compact-02
, the Computed tab was not showing the line height and letter spacing for me, and they looked the same size so just double checking that they should be this:
heading-compact-01
should be:
Size: 14px / 0.875rem
Line height: 18px / 1.125rem
Letter spacing: .16px
heading-compact-02
should be:
Size: 16px / 1rem
Line height: 22px / 1.375rem
Letter spacing: 0px
quotation-01
and fluid-quotation-01
should be using IBM Plex Serif instead of Sans.
quotation-02
and fluid-quotation-02
should be using IBM Plex Serif instead of Sans.
heading-01
andexpressive-heading-01
should be:
Line height: 20px / 1.25rem
heading-02
and expressive-heading-02
should be:
Line height: 24px / 1.5rem
d917e44
to
f274cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked again today after changes and it looks good to me! 👍
Closes #9377
This PR adds in a few new type tokens, as well as aliasing old type-token names to their new V11 token name. The old values will be removed in V12.
Changelog
New
legal-01
andlegal-02
added as net new tokensChanged
-Old token names are set as values of token names in blue
Removed
Testing / Reviewing
Token values have been set to align with the Notion doc