Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sketch): update plugin to emit hover color palette #9387

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 2, 2021

Closes #9253

Updates the commands for sync shared layer styles, sync color variables, and generate color page to emit the hover color palette from @carbon/colors

Changelog

Changed

  • sketch: core and hover palettes are now in two separate folders for both variables and shared layer styles
    • eg. color / core / red / red 60 and color / hover / red hover / red hover 60
  • sketch: generate color page includes hover colors in proper order

Testing / Reviewing

Pull down the branch, spin up the sketch plugin locally, try out the three color commands from the plugins menu.

The generated color page should include hover colors

Screen Shot 2021-08-04 at 3 14 14 PM

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: c5fb540

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611c085c46b72500089e4c30

😎 Browse the preview: https://deploy-preview-9387--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: c5fb540

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611c085cafc4ec000802b662

😎 Browse the preview: https://deploy-preview-9387--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 2, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c5fb540

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611c085cdef39b00085b5729

😎 Browse the preview: https://deploy-preview-9387--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

Looking good! Any feedback that you're looking for specifically while this is a draft PR?

@joshblack joshblack removed their request for review August 3, 2021 21:43
@tay1orjones tay1orjones changed the title feat(sketch): update shared layer styles to include hover palette feat(sketch): update plugin to emit hover palette Aug 4, 2021
@tay1orjones tay1orjones changed the title feat(sketch): update plugin to emit hover palette feat(sketch): update plugin to emit hover color palette Aug 4, 2021
@tay1orjones tay1orjones marked this pull request as ready for review August 4, 2021 20:26
@tay1orjones tay1orjones requested a review from a team as a code owner August 4, 2021 20:26
@tay1orjones
Copy link
Member Author

Looking good!

@joshblack I think that's exactly the type of preliminary feedback @andreancardona and I were looking for 😄 just something to see if we were on the right track.

Now we've completed the rest of the line items from the initial issue and I've marked this ready for review 👍

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it locally but from the screenshot provided it looks correctly organized!

@sstrubberg sstrubberg enabled auto-merge (squash) August 17, 2021 19:04
@sstrubberg sstrubberg merged commit 24e53e7 into carbon-design-system:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Sketch Plugin to emit hover colors
5 participants