-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sketch): update plugin to emit hover color palette #9387
feat(sketch): update plugin to emit hover color palette #9387
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: c5fb540 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611c085c46b72500089e4c30 😎 Browse the preview: https://deploy-preview-9387--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: c5fb540 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611c085cafc4ec000802b662 😎 Browse the preview: https://deploy-preview-9387--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: c5fb540 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611c085cdef39b00085b5729 😎 Browse the preview: https://deploy-preview-9387--carbon-components-react.netlify.app |
Looking good! Any feedback that you're looking for specifically while this is a draft PR? |
@joshblack I think that's exactly the type of preliminary feedback @andreancardona and I were looking for 😄 just something to see if we were on the right track. Now we've completed the rest of the line items from the initial issue and I've marked this ready for review 👍 |
…bon into 9253-sketch-hover-colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it locally but from the screenshot provided it looks correctly organized!
Closes #9253
Updates the commands for
sync shared layer styles
,sync color variables
, andgenerate color page
to emit the hover color palette from@carbon/colors
Changelog
Changed
color / core / red / red 60
andcolor / hover / red hover / red hover 60
generate color page
includes hover colors in proper orderTesting / Reviewing
Pull down the branch, spin up the sketch plugin locally, try out the three color commands from the
plugins
menu.The generated color page should include hover colors