Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Visual Regression Tests for Checkbox #9324

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Add Visual Regression Tests for Checkbox #9324

merged 5 commits into from
Aug 2, 2021

Conversation

tay1orjones
Copy link
Member

Closes #9266

Adds some simple visual regression tests for Checkbox and CheckboxSkeleton to be surfaced in percy.io

Changelog

New

  • checkbox: visual regression tests

Testing / Reviewing

Clicking into the percy status check to view the Percy UI should show new snapshots for checkbox and checkbox skeleton.

@tay1orjones tay1orjones requested a review from a team as a code owner July 26, 2021 19:46
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: de6ef78

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61086791d5b8d200087bd610

😎 Browse the preview: https://deploy-preview-9324--carbon-react-next.netlify.app

@tay1orjones tay1orjones requested a review from jnm2377 July 26, 2021 19:46
@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: de6ef78

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6108679169aeb70007a2a2e9

😎 Browse the preview: https://deploy-preview-9324--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 26, 2021 •
edited
Loading

❌ Deploy Preview for carbon-components-react failed.

🔨 Explore the source changes: de6ef78

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6108679133b387000856c8f4

andreancardona
andreancardona approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@tay1orjones
Copy link
Member Author

tay1orjones commented Jul 30, 2021 •
edited
Loading

@dakahn @andreancardona The build snapshots will have to be approved as well in the Percy UI via the details link in the status checks section

@kodiakhq kodiakhq bot merged commit a83021a into carbon-design-system:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@andreancardona andreancardona andreancardona approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VRT for Checkbox
4 participants
@tay1orjones @jnm2377 @andreancardona @dakahn