Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): add components migration docs #9255

Merged

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jul 22, 2021

Closes #9171

This PR adds in the initial migration document for carbon-components. There are several TODO items that will need to be addressed in a future sprint that are called out in the document.

Changelog

New

Changed

  • Update v11.x document with more blurbs
  • Update carbon-components with all "public API files" and their changes included

Removed

Testing / Reviewing

  • Take a look at the structure of the migration doc and see if it makes sense
  • Review several of the blurbs for migration of a specific file and see if the format makes sense
  • Leave any comments, questions, or concerns that you might have! I'd love to hear them

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3e628d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6103203b39f10a0007ad2426

😎 Browse the preview: https://deploy-preview-9255--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3e628d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6103203b2753240007acc2ab

😎 Browse the preview: https://deploy-preview-9255--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3e628d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6103203bba80fc0007194d84

😎 Browse the preview: https://deploy-preview-9255--carbon-components-react.netlify.app

@joshblack joshblack marked this pull request as ready for review July 22, 2021 21:21
@joshblack joshblack requested a review from a team as a code owner July 22, 2021 21:21
@andreancardona
Copy link
Contributor

This is awesome by the way! @joshblack

joshblack and others added 2 commits July 28, 2021 10:43
@joshblack
Copy link
Contributor Author

Let me know if you have any questions @tw15egan @jnm2377!

@andreancardona andreancardona self-requested a review July 29, 2021 20:48
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much docs!

@sstrubberg sstrubberg enabled auto-merge (squash) July 29, 2021 21:40
@sstrubberg sstrubberg merged commit 6f8cafb into carbon-design-system:main Jul 29, 2021
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really awesome, nice work @joshblack 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write initial migration docs for carbon-components to @carbon/styles
4 participants