Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carbon-react): add Layer component #9236

Merged

Conversation

joshblack
Copy link
Contributor

Closes #9185

This PR adds in the Layer component and associated layer set tokens in @carbon/styles.

Changelog

New

  • Add Layer component to @carbon/react

Changed

  • Update scss/_theme.scss to include layer sets

Removed

Testing / Reviewing

  • Verify tests pass as expected
  • View the storybook story and make sure that the var(--bx-layer) token is changing as intended across each theme we support

@joshblack joshblack requested a review from a team as a code owner July 20, 2021 22:19
@joshblack joshblack requested review from emyarod and sstrubberg July 20, 2021 22:19
@netlify
Copy link

netlify bot commented Jul 20, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9d154c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f82d693563930007db7749

😎 Browse the preview: https://deploy-preview-9236--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 20, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9d154c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f82d69ca89a30008eee639

😎 Browse the preview: https://deploy-preview-9236--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 20, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 9d154c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f82d69806d1f0008938cbf

😎 Browse the preview: https://deploy-preview-9236--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 20bd64b into carbon-design-system:main Jul 21, 2021
@joshblack joshblack deleted the 9185-add-layer-component branch July 21, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build out a Layer component as a replacement for the light prop
3 participants