Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons-react): add elements section & icon next stories #9147

Merged
merged 5 commits into from
Sep 9, 2021
Merged

feat(icons-react): add elements section & icon next stories #9147

merged 5 commits into from
Sep 9, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jul 8, 2021

Closes #8904

New

  • adds Icons story

Changed

  • moved Grid and Plex stories to the Elements section

Testing / Reviewing

Go to carbon-react-next preview, or checkout locally. Verify icons stories are rendering correctly with the new size prop.

@jnm2377 jnm2377 requested a review from a team as a code owner July 8, 2021 17:22
@jnm2377 jnm2377 requested review from emyarod and dakahn July 8, 2021 17:22
@jnm2377 jnm2377 changed the title feat: add elements section & icon stories feat(icons-react): add elements section & icon next stories Jul 8, 2021
@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 294a560

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/613a814151d3b10008171564

@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 294a560

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/613a8141e85840000726c352

😎 Browse the preview: https://deploy-preview-9147--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 294a560

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/613a814195e33000070ab867

😎 Browse the preview: https://deploy-preview-9147--carbon-components-react.netlify.app

emyarod
emyarod reviewed Jul 9, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are a couple of lint errors, otherwise looks good to me

@jnm2377 jnm2377 requested review from a team and jharvey10 and removed request for a team September 5, 2021 00:55
dakahn
dakahn approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cool to me 👍🏾

@kodiakhq kodiakhq bot merged commit c1e34b2 into carbon-design-system:main Sep 9, 2021
This was referenced Sep 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@jharvey10 jharvey10 Awaiting requested review from jharvey10

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for @carbon/icons-react usage in @carbon/react to Storybook
4 participants
@jnm2377 @joshblack @emyarod @dakahn