Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FormGroup): support id on fieldset legend #9074

Merged
merged 4 commits into from
Jul 8, 2021
Merged

feat(FormGroup): support id on fieldset legend #9074

merged 4 commits into from
Jul 8, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jun 30, 2021

Closes #9072

This PR adds a legendId prop to FormGroup legend and syncs it with aria-labelledby if it is already provided. If not, the aria-labelledby on the fieldset will fall back to the legendId value

Testing / Reviewing

Verify that the FormGroup aria-labelledby on fieldset matches with the legendId when one of the values is provided, and confirm that the props match the provided values if both are provided

@emyarod emyarod requested a review from a team as a code owner June 30, 2021 15:53
@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 09fe996

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e70d765c08e70007346b37

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 09fe996

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e70d762cabdb00083fa56d

😎 Browse the preview: https://deploy-preview-9074--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 09fe996

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e70d76983f8700073791eb

😎 Browse the preview: https://deploy-preview-9074--carbon-components-react.netlify.app

@emyarod emyarod requested a review from a team as a code owner June 30, 2021 16:37
andreancardona
andreancardona approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@emyarod emyarod force-pushed the 9072-formgroup-legend-id branch from d9d03f9 to 67f3fc0 Compare July 6, 2021 14:26
@emyarod
Copy link
Member Author

emyarod commented Jul 7, 2021

bump @tw15egan when you have some time!

tw15egan
tw15egan approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 4fc56c3 into carbon-design-system:main Jul 8, 2021
@emyarod emyarod deleted the 9072-formgroup-legend-id branch July 8, 2021 14:59
@emyarod emyarod mentioned this pull request Jul 12, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom legend id in fieldset for FormGroup and RadioButtonGroup React components
3 participants
@emyarod @tw15egan @andreancardona