-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tooltip): sass module refactor #8982
feat(Tooltip): sass module refactor #8982
Conversation
…69-tooltip-sass-refactor
… into 8969-tooltip-sass-refactor
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9a0e3fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d119853407dc000709eae9 😎 Browse the preview: https://deploy-preview-8982--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 922c9b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60db37199e672400071b1360 😎 Browse the preview: https://deploy-preview-8982--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9a0e3fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d11985804e88000866edf3 😎 Browse the preview: https://deploy-preview-8982--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 922c9b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60db371994276d00074db32d 😎 Browse the preview: https://deploy-preview-8982--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how they're being handled in the sass module refactor but $caret-size
seems like a component token
it looks like CI is failing since the timing function variables are not defined as well
Error: Undefined variable.
╷
128 │ transition: opacity $duration--fast-01 motion(standard, productive);
│ ^^^^^^^^^^^^^^^^^^
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 922c9b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60db3719a2a0c000092a45c7 😎 Browse the preview: https://deploy-preview-8982--carbon-react-next.netlify.app/iframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dakahn I think that variable needs to be updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving for now pending update on the $duration-fast-01
variable
Looks good 🎉
…69-tooltip-sass-refactor
… into 8969-tooltip-sass-refactor
Closes #8969
Tooltip sass module refactor 🏄🏽
Testing / Reviewing
Everything should be exactly how you remember it. 🙏🏽