Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tooltip): sass module refactor #8982

Merged
merged 14 commits into from
Jun 29, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jun 21, 2021

Closes #8969

Tooltip sass module refactor 🏄🏽

Testing / Reviewing

Everything should be exactly how you remember it. 🙏🏽

@dakahn dakahn requested a review from a team as a code owner June 21, 2021 22:58
@dakahn dakahn requested review from emyarod and andreancardona June 21, 2021 22:58
@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9a0e3fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d119853407dc000709eae9

😎 Browse the preview: https://deploy-preview-8982--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 922c9b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60db37199e672400071b1360

😎 Browse the preview: https://deploy-preview-8982--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 9a0e3fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d11985804e88000866edf3

😎 Browse the preview: https://deploy-preview-8982--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jun 21, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 922c9b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60db371994276d00074db32d

😎 Browse the preview: https://deploy-preview-8982--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how they're being handled in the sass module refactor but $caret-size seems like a component token

it looks like CI is failing since the timing function variables are not defined as well

Error: Undefined variable.

128 │     transition: opacity $duration--fast-01 motion(standard, productive);
    │                         ^^^^^^^^^^^^^^^^^^

@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 922c9b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60db3719a2a0c000092a45c7

😎 Browse the preview: https://deploy-preview-8982--carbon-react-next.netlify.app/iframe

@dakahn dakahn requested a review from emyarod June 22, 2021 23:43
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "custom icon only" story still has the label, is that difference from the original story intentional?

image

@andreancardona
Copy link
Contributor

not sure how they're being handled in the sass module refactor but $caret-size seems like a component token

it looks like CI is failing since the timing function variables are not defined as well

Error: Undefined variable.
    ╷
128 │     transition: opacity $duration--fast-01 motion(standard, productive);
    │                         ^^^^^^^^^^^^^^^^^^

@dakahn I think that variable needs to be updated to $duration-fast-01 (single dash across the whole variable)

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for now pending update on the $duration-fast-01 variable

Looks good 🎉

@dakahn dakahn requested a review from emyarod June 23, 2021 22:04
@kodiakhq kodiakhq bot merged commit 1041df6 into carbon-design-system:main Jun 29, 2021
@jnm2377 jnm2377 mentioned this pull request Jul 6, 2021
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Tooltip): add Tooltip to @carbon/styles
3 participants