Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): sass module refactor #8967

Merged
merged 8 commits into from
Jun 25, 2021
Merged

feat(search): sass module refactor #8967

merged 8 commits into from
Jun 25, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jun 21, 2021

Closes #8940

Sass module refactor for Search component

Testing

Component should behave and appear the same 👍🏽

@dakahn dakahn requested a review from a team as a code owner June 21, 2021 16:02
@dakahn dakahn requested review from tay1orjones and sstrubberg June 21, 2021 16:02
@netlify
Copy link

netlify bot commented Jun 21, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 17decdc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d5fe6efb43fb00082e404b

😎 Browse the preview: https://deploy-preview-8967--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 21, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 17decdc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d5fe6e902a36000781eed5

😎 Browse the preview: https://deploy-preview-8967--carbon-components-react.netlify.app

@dakahn dakahn changed the title 8940 search sass module refactor WIP | feat(search): sass module refactor Jun 21, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 17decdc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d5fe6e902a36000781eeda

😎 Browse the preview: https://deploy-preview-8967--carbon-react-next.netlify.app

@dakahn dakahn changed the title WIP | feat(search): sass module refactor feat(search): sass module refactor Jun 22, 2021
@dakahn
Copy link
Contributor Author

dakahn commented Jun 22, 2021

Seems like the styles are broken in the Story -- :| ON IT

tay1orjones
tay1orjones requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple super minor things

packages/styles/scss/components/search/_search.scss Outdated Show resolved Hide resolved
packages/styles/scss/components/search/_search.scss Outdated Show resolved Hide resolved
@dakahn dakahn requested a review from tay1orjones June 23, 2021 22:15
@dakahn dakahn mentioned this pull request Jun 23, 2021
Closed
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 25, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@tw15egan tw15egan force-pushed the 8940-search-sass-module-refactor branch from 5610ca2 to c09caff Compare June 25, 2021 15:00
@kodiakhq kodiakhq bot merged commit 9448370 into carbon-design-system:main Jun 25, 2021
@tw15egan tw15egan mentioned this pull request Jun 28, 2021
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(Search): add Search to @carbon/styles
4 participants
@dakahn @tay1orjones @tw15egan @sstrubberg