Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(number-input): refactor with testing #8935

Merged
merged 5 commits into from
Jun 22, 2021
Merged

feat(number-input): refactor with testing #8935

merged 5 commits into from
Jun 22, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Jun 16, 2021 •
edited
Loading

Closes #8919

  • Refactors NumberInput to SASS modules

Testing:

  • run yarn test --watch packages/styles/scss/components/__tests__/number-input-test.js
  • Make sure tests pass
  • cd packages/carbon-react run yarn storybook to make sure none of the styles are broken

REVIEWS help me confirm the new variable name is in fact $duration-fast-01 thank you :)

@andreancardona andreancardona requested a review from a team as a code owner June 16, 2021 21:24
@andreancardona andreancardona marked this pull request as draft June 16, 2021 21:29
@netlify
Copy link

netlify bot commented Jun 16, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 292dcb3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d23470986d690008e6e818

😎 Browse the preview: https://deploy-preview-8935--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 16, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 292dcb3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d23470986d690008e6e813

😎 Browse the preview: https://deploy-preview-8935--carbon-components-react.netlify.app

@andreancardona andreancardona marked this pull request as ready for review June 16, 2021 22:23
@andreancardona andreancardona requested a review from joshblack June 17, 2021 14:40
joshblack
joshblack suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment!

Side-note, would it make sense to add the storybook stories to @carbon/react for this component to double-check that the styles look correct? 👀

packages/styles/scss/components/number-input/_number-input.scss Show resolved Hide resolved
@emyarod
Copy link
Member

emyarod commented Jun 17, 2021

@joshblack should we be expecting storybook changes in other sass module reviews as well?

@joshblack
Copy link
Contributor

@emyarod good question, might make sense to add to the checklist

@andreancardona
Copy link
Contributor Author

@joshblack should we be expecting storybook changes in other sass module reviews as well?

Thank you for the feedback ya'll I'll make sure to add!

@andreancardona
Copy link
Contributor Author

@joshblack @emyarod storybook was added for styles. Let me know what other feedback ya'll might have!

@andreancardona andreancardona mentioned this pull request Jun 21, 2021
Closed
sstrubberg
sstrubberg approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

emyarod
emyarod approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 292dcb3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d2347056868f00084b26ec

😎 Browse the preview: https://deploy-preview-8935--carbon-react-next.netlify.app/iframe

@kodiakhq kodiakhq bot merged commit b9e5263 into carbon-design-system:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Number Input to use Sass modules
5 participants
@andreancardona @emyarod @joshblack @sstrubberg @tw15egan