-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio-button): add position rule to button group wrapper #8933
fix(radio-button): add position rule to button group wrapper #8933
Conversation
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 89b474b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d48e1028012300076e2a2b 😎 Browse the preview: https://deploy-preview-8933--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 89b474b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d48e10b849850008006d72 😎 Browse the preview: https://deploy-preview-8933--carbon-components-react.netlify.app/iframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
bump @jnm2377 when you have a chance |
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 89b474b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d48e1029b424000868a1bb 😎 Browse the preview: https://deploy-preview-8933--carbon-react-next.netlify.app |
Closes #8932
This PR adds a
position
rule to the radio buttonfieldset
wrapper to avoid the invisible inputs adding overflow to their containersTesting / Reviewing
Replicate the issue using the sandbox example in the original ticket and modify it according to the changes in the PR to observe the overflow/lack of overflow