Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio-button): add position rule to button group wrapper #8933

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jun 16, 2021

Closes #8932

This PR adds a position rule to the radio button fieldset wrapper to avoid the invisible inputs adding overflow to their containers

Testing / Reviewing

Replicate the issue using the sandbox example in the original ticket and modify it according to the changes in the PR to observe the overflow/lack of overflow

@emyarod emyarod requested a review from a team as a code owner June 16, 2021 19:01
@emyarod emyarod requested review from tw15egan and jnm2377 June 16, 2021 19:01
@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 89b474b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d48e1028012300076e2a2b

😎 Browse the preview: https://deploy-preview-8933--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 89b474b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d48e10b849850008006d72

😎 Browse the preview: https://deploy-preview-8933--carbon-components-react.netlify.app/iframe

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@emyarod
Copy link
Member Author

emyarod commented Jun 23, 2021

bump @jnm2377 when you have a chance

@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 89b474b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d48e1029b424000868a1bb

😎 Browse the preview: https://deploy-preview-8933--carbon-react-next.netlify.app

@kodiakhq kodiakhq bot merged commit f2b5084 into carbon-design-system:main Jun 24, 2021
@emyarod emyarod deleted the 8932-radio-button-wrapper-position-rule branch June 24, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio button group: needs relative positioning when used inside a scrolling element
3 participants