fix(InlineLoading): add iconDescription to error and finished SVGs #8918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
approved these changes
Jun 15, 2021
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 449e72c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60cb7bb6a439a90008ce769b 😎 Browse the preview: https://deploy-preview-8918--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 449e72c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60cb7bb61f7977000713135a 😎 Browse the preview: https://deploy-preview-8918--carbon-components-react.netlify.app/iframe |
dakahn
approved these changes
Jun 16, 2021
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8828
This PR adds
iconDescriptionto the success and error icons in InlineLoadingTesting / Reviewing
Set the InlineLoading
statusto'error'or'finished'and confirm that the providediconDescriptionis still visible