Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Definition Tooltip): add definition tooltip #8871

Closed

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jun 9, 2021

Closes #8814

Implements v11 /next/TooltipDefinition

Testing / Reviewing

In the Storybook make sure that the unstable_Tooltip / Definition story works and appears as intended.

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: bfeafc4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c11f25c7c8cc00075a3819

😎 Browse the preview: https://deploy-preview-8871--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 5e66ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c11f3103bea9000709bb9f

😎 Browse the preview: https://deploy-preview-8871--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: bfeafc4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c11f25d3b76200076be845

😎 Browse the preview: https://deploy-preview-8871--carbon-components-react.netlify.app/iframe

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 5e66ac7

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c11f31878a5d0007dd28f2

😎 Browse the preview: https://deploy-preview-8871--carbon-components-react.netlify.app

@dakahn dakahn requested a review from joshblack June 9, 2021 21:15
@dakahn
Copy link
Contributor Author

dakahn commented Jun 9, 2021

@joshblack throwing you on this for a PR review -- just wanna make sure I hit what I needed to hit API wise

onBlur={composeEventHandlers([onBlur, handleBlur])}>
{children}
</button>
<div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure this component uses Popover directly, it should mean that we won't need the debounce or mouseover/mouseout handlers 👍

@joshblack joshblack closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement definition tooltip styles for Tooltip next
3 participants