-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Definition Tooltip): add definition tooltip #8871
feat(Definition Tooltip): add definition tooltip #8871
Conversation
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: bfeafc4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c11f25c7c8cc00075a3819 😎 Browse the preview: https://deploy-preview-8871--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 5e66ac7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60c11f3103bea9000709bb9f 😎 Browse the preview: https://deploy-preview-8871--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: bfeafc4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c11f25d3b76200076be845 😎 Browse the preview: https://deploy-preview-8871--carbon-components-react.netlify.app/iframe |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 5e66ac7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60c11f31878a5d0007dd28f2 😎 Browse the preview: https://deploy-preview-8871--carbon-components-react.netlify.app |
@joshblack throwing you on this for a PR review -- just wanna make sure I hit what I needed to hit API wise |
onBlur={composeEventHandlers([onBlur, handleBlur])}> | ||
{children} | ||
</button> | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure this component uses Popover
directly, it should mean that we won't need the debounce or mouseover/mouseout handlers 👍
Closes #8814
Implements v11 /next/TooltipDefinition
Testing / Reviewing
In the Storybook make sure that the unstable_Tooltip / Definition story works and appears as intended.