Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tokens): add expressive tokens #8543

Merged

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Apr 30, 2021

Closes #8299

adds expressive type tokens;

  • caption-02
  • label-02
  • helper-text-02

Changelog

Changed

  • add expressive tokens to packages/type/scss/_styles.scss
  • add expressive tokens to packages/type/src/styles.js
  • add expressive tokens to packages/type/src/tokens.js

@dakahn dakahn requested a review from a team as a code owner April 30, 2021 01:29
@dakahn dakahn requested review from joshblack and emyarod April 30, 2021 01:29
@netlify
Copy link

netlify bot commented Apr 30, 2021

Deploy preview for carbon-elements ready!

Built with commit 9eaf706

https://deploy-preview-8543--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 30, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 9eaf706

https://deploy-preview-8543--carbon-components-react.netlify.app

@dakahn
Copy link
Contributor Author

dakahn commented Apr 30, 2021

Hmmm -- CI failing with unkown primitive... exception. 😕

@emyarod emyarod requested a review from shixiedesign April 30, 2021 14:58
@joshblack
Copy link
Contributor

@dakahn just pushed up a quick update, the values were missing from the theme so when the "builder" was generating the files it couldn't find the value of the token in the theme.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like snapshots need to be updated to pass CI

Copy link
Contributor

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the preview! Thank you!!

@dakahn dakahn requested a review from a team as a code owner May 5, 2021 17:42
@dakahn dakahn requested a review from emyarod May 5, 2021 17:58
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 9a1da9a into carbon-design-system:main May 6, 2021
@tw15egan tw15egan mentioned this pull request May 10, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type tokens for expressive reading experience
5 participants