-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tokens): add expressive tokens #8543
feat(Tokens): add expressive tokens #8543
Conversation
Deploy preview for carbon-elements ready! Built with commit 9eaf706 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 9eaf706 https://deploy-preview-8543--carbon-components-react.netlify.app |
Hmmm -- CI failing with |
@dakahn just pushed up a quick update, the values were missing from the theme so when the "builder" was generating the files it couldn't find the value of the token in the theme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like snapshots need to be updated to pass CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in the preview! Thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Closes #8299
adds expressive type tokens;
caption-02
label-02
helper-text-02
Changelog
Changed