fix(react): update table header unique id to use stable id #7730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit be8b33c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit be8b33c https://deploy-preview-7730--carbon-components-react.netlify.app |
dakahn
approved these changes
Feb 3, 2021
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7721
Updates
TableHeaderto leverageuseIdversusMath.randomfor an internal unique id. While this doesn't prevent all randomness, there is a deterministic order that should make it easier for teams that use snapshot testing to snapshot components that containTableHeader.Changelog
New
Changed
TableHeaderto useuseIdversusMath.randomRemoved
Testing / Reviewing
ids generated and applied